-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Disable tests/run-make/mte-ffi
because no CI runners have MTE extensions enabled
#142300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
[EXPERIMENTAL] Revert `mte-ffi` changes See #141600. try-job: aarch64-gnu try-job: aarch64-gnu-llvm-19-1
This comment was marked as off-topic.
This comment was marked as off-topic.
@bors2 try |
[EXPERIMENTAL] Revert `mte-ffi` changes See #141600. try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
e22aa15
to
3e712e5
Compare
mte-ffi
changesmte-ffi
changes
mte-ffi
changesmte-ffi
changes
3e712e5
to
45682df
Compare
This comment has been minimized.
This comment has been minimized.
4ce5f14
to
1f9346c
Compare
@bors2 try jobs=aarch64-gnu |
[EXPERIMENTAL] Revert `mte-ffi` changes Based on > > it failed on aarch64 (on the new aarch64-gnu-llvm-19-1 job introduced in this PR) > > This feature requires ARMv8.5 or higher. And it has to be enabled. Maybe the CI job runner does not support this extension? Let's revert the changes to this test in #141576. However, I can't explain why the test manages to *pass* on `aarch64-gnu` but not `aarch64-gnu-llvm-1` #141600. ### References - https://www.kernel.org/doc/html/v5.10/arm64/memory-tagging-extension.html try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
1f9346c
to
c6cc140
Compare
@bors2 try jobs=aarch64-gnu |
[EXPERIMENTAL] Revert `mte-ffi` changes Based on > > it failed on aarch64 (on the new aarch64-gnu-llvm-19-1 job introduced in this PR) > > This feature requires ARMv8.5 or higher. And it has to be enabled. Maybe the CI job runner does not support this extension? Let's revert the changes to this test in #141576. However, I can't explain why the test manages to *pass* on `aarch64-gnu` but not `aarch64-gnu-llvm-1` #141600. ### References - https://www.kernel.org/doc/html/v5.10/arm64/memory-tagging-extension.html try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
aarch64-gnu-llvm-19-1
|
aarch64-gnu
|
mte-ffi
changestests/run-make/mte-ffi
because no CI runners have MTE extensions enabled
Partially reverts commit 40311c4.
See RUST-141600: this test is broken in two ways: 1. This test triggers `-Wincompatible-pointer-types` on GCC 14. 2. This test requires ARMv8.5+ w/ MTE extensions enabled, but GHA CI runner hardware do not have this enabled.
c6cc140
to
37136dd
Compare
rustbot has assigned @Mark-Simulacrum. Use |
(Mark has a ton of assigned PRs) |
@bors r+ rollup |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
This PR disables the
tests/run-make/mte-ffi
run-make test because it is (1) broken, and (2) no CI runners have suitable MTE extensions enabled to run it correctly. This test being broken is tracked by #141600.The first commit also reverts
mte-ffi
changes introduced in #141576, as those fixes potentially changes the meaning of the test.cc @dheaton-arm (as this test was introduced in #128384)
Context
In #141576 when converting PR CI runners from x86_64 to aarch64 runners, it was noticed that this test failed on
aarch64-gnu-llvm-19-1
but notaarch64-gnu
. It turns out that:aarch64-gnu-llvm-19-1
gcc version 14.2.0 (Ubuntu 14.2.0-4ubuntu2)
lscpu
output, the hardware that was used for this runner does not have MTE enabled.aarch64-gnu
gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
lscpu
output, the hardware that was used for this runner does not have MTE enabled.Based on this comment, it seems like the test requires hardware with MTE extensions enabled to run properly (on ARMv8.5 or higher).
Furthermore, I believe this test does indeed have mismatched pointer type issues, i.e.
Which is only exposed by
aarch64-gnu-llvm-19-1
becauseaarch64-gnu-llvm-19-1
uses gcc 14.2.0 whereasaarch64-gnu
uses gcc 11.14.0.Details
aarch64-gnu-llvm-19-1
aarch64-gnu
References
cc @marcoieni as this PR reverts the
tests/run-make/mte-ffi
changes from #141576.